[pull] develop from frappe:develop#372
Merged
Merged
Conversation
- Rename Balance column to Outstanding Amount - Add Department, Branch, Advance Account filters with multi-select support - Add Group By filter (Employee, Department, Branch) with subtotals and grand total - Add Advance Account column to report output - Resolve department from Employee record when not set on Employee Advance - Add bold formatter for group header rows Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…Summary - Use frappe._dict(filters) and dot-access instead of filters.get() - Use frappe.utils.scrub() to derive group field from group_by label - Use OrderedDict for deterministic group ordering (as in gross_profit report) - Remove manual GROUP_BY_FIELDS mapping - Use frappe.query_builder.Order instead of pypika.Order - Build result rows inline during grouping iteration Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…oyee Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nd group header Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Revert filters.key dot-access to filters.get("key") to match hrms conventions
- Remove group_field variable; use scrub(filters.get("group_by")) inline
matching gross_profit report pattern
- Show employee ID and name in Employee column and group header
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…y creation to avoid empty exchange gain/loss account error
…ry-report feat(report): enhance Employee Advance Summary report
…ent_exchange_rate fix: creating payment entry for Employee Advance asks for Exchange Gain/Loss Account even for same currency
fix: add permission check for insert_shift mutations
… and joining date
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )