[pull] develop from frappe:develop#364
Merged
Merged
Conversation
…mployee Incentive Employee Incentive filtered Salary Components using the Salary Component.company field, which triggered field-level permission checks and caused a Permission Error for users without access to that field. Updated the filtering logic to derive company-specific Salary Components from Salary Component Account instead of directly accessing Salary Component.company. This preserves the intended filtering behavior while preventing permission errors when selecting Salary Components in Employee Incentive. Fixes #4690
fix: package frontend and roster assets from public dir
fix(payroll): use Salary Component Account for company filtering in Employee Incentive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )