Skip to content

terraform: add CloudWatch log group retention policy#237

Merged
thiagoesteves merged 1 commit into
thiagoesteves:mainfrom
igor-soldev:terraform/cloudwatch-log-retention-clean
Jul 1, 2026
Merged

terraform: add CloudWatch log group retention policy#237
thiagoesteves merged 1 commit into
thiagoesteves:mainfrom
igor-soldev:terraform/cloudwatch-log-retention-clean

Conversation

@igor-soldev

Copy link
Copy Markdown
Contributor

Add retention_in_days to aws_cloudwatch_log_group in the standard-account module for aws-elixir, aws-erlang and aws-gleam. Without this, AWS retains logs indefinitely by default, leading to unbounded storage costs.

A new optional variable log_retention_in_days (default: 30 days) is introduced in each module's variables.tf. No existing callers need to be updated. The default of 30 days matches the value already used in the aws-elixir-db-certificate module, the only module that had retention configured prior to this change.

Relates to the CloudWatch Logs Without Retention finding flagged in #236.

@thiagoesteves thiagoesteves left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for submitting

@thiagoesteves thiagoesteves merged commit 1fa8d4e into thiagoesteves:main Jul 1, 2026
5 of 6 checks passed
thiagoesteves added a commit that referenced this pull request Jul 8, 2026
…guide (#244)

* Update changelog with 0.9.5 entries and document changelog maintenance

Add the missing 0.9.5 entries for the merged PRs: #239, #240, #241 and
#242 as bug fixes, and #237 (CloudWatch log group retention) as an
enhancement. Document the changelog maintenance rules in AGENTS.md so
agents know how to add entries, and remove the outdated note that said
the changelog must not be edited manually.

Risk assessment:
- Impact: documentation only, no runtime behavior changes.
- Blast radius: CHANGELOG.md and AGENTS.md.
- Regression risk: none, docs-only diff.
- Rollback: revert this commit.

* Updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants