feat(trace): append /trace to chip URL for cctrace 0.39 - #17
Merged
Conversation
cctrace 0.39 moved the live trace view from / to /trace (root now redirects to /dashboard). The trace chip URL and DEVA_TRACE_UI_URL now append /trace so terminal-linkified clicks land on the trace view, not the dashboard. Also fixes a test env leak: DEVA_TRACE_UI_URL was not unset in the test helper, causing false failures when running inside a traced deva container. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/trace— cctrace 0.39 moved the live view from/to/trace(root now 302s to/dashboard)DEVA_TRACE_UI_URLgets trailing-slash-safe/traceappendDEVA_TRACE_UI_URLadded to the unset list int/helpers.bash— was causing false failures inside traced containersTest plan
proj [http://localhost:9317/trace]