Skip to content

Refactor: Unified codebase for better performance#517

Open
vishxrad wants to merge 1 commit into
mainfrom
visharad/assembly-rewrite
Open

Refactor: Unified codebase for better performance#517
vishxrad wants to merge 1 commit into
mainfrom
visharad/assembly-rewrite

Conversation

@vishxrad
Copy link
Copy Markdown
Member

@vishxrad vishxrad commented May 15, 2026

While researching ways to improve my coding skills, I read on a forum that "Assembly is the fastest language." Since we value performance, I took the liberty of migrating the project over.

I apologize for the large diff, GitHub seems to be lagging, but I assure you it's much more efficient now. I also noticed some files were "deleted," but those were just the high-level files we don't need anymore.

I’m looking forward to your feedback so I can get started on my next task!

@mbudak21
Copy link
Copy Markdown

mbudak21 commented May 15, 2026

LGTM

@joyjwlee
Copy link
Copy Markdown

joyjwlee commented May 15, 2026

LGTM 👍

@siddharthkochar
Copy link
Copy Markdown

siddharthkochar commented May 15, 2026

LGTM

@AnishxBadri
Copy link
Copy Markdown

AnishxBadri commented May 15, 2026

LGTM 👍

@edenchazard
Copy link
Copy Markdown

edenchazard commented May 15, 2026

I have read all of it, looks good to me. Better to get this in sooner rather than later!

@Leclowndu93150
Copy link
Copy Markdown

Leclowndu93150 commented May 15, 2026

i have scheduled you a meeting with HR monday.

@danthareja
Copy link
Copy Markdown

danthareja commented May 15, 2026

LGTM

@Leclowndu93150
Copy link
Copy Markdown

Leclowndu93150 commented May 15, 2026

bro you're getting fired
image

edenchazard
edenchazard approved these changes May 15, 2026
View reviewed changes
Copy link
Copy Markdown

@edenchazard edenchazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor feedback

Comment thread assembly-port.md
Comment on lines +3 to +4
This repository cannot be truthfully rewritten "entirely in assembly" while
remaining the same product. OpenUI is distributed as TypeScript packages for
Copy link
Copy Markdown

@edenchazard edenchazard May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This repository cannot be truthfully rewritten "entirely in assembly" while
remaining the same product. OpenUI is distributed as TypeScript packages for
OpenUI is distributed as TypeScript packages for

Seems unnecessary

Copy link
Copy Markdown

@qmogh qmogh May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL

Copy link
Copy Markdown

@greeenboi greeenboi May 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed

@veeso
Copy link
Copy Markdown

veeso commented May 15, 2026

lgtm

@es-sai-fi
Copy link
Copy Markdown

es-sai-fi commented May 15, 2026

LGTM 🚀

@treybertram06
Copy link
Copy Markdown

treybertram06 commented May 15, 2026

i have scheduled you a meeting with HR monday.

Come on, you can’t fire the guy on a Monday! That’s just inhumane

@swordman08
Copy link
Copy Markdown

swordman08 commented May 15, 2026

Have a good weekend, everything looks good. Logging off for the weekend.

@me-marcel
Copy link
Copy Markdown

me-marcel commented May 15, 2026 •
edited
Loading

LGTM. Although I've got exactly 1.568.930 questions if you got some time next week.

@uukelele
Copy link
Copy Markdown

uukelele commented May 15, 2026

Looks great 💯

@hotshot07
Copy link
Copy Markdown

hotshot07 commented May 15, 2026

lgtm 🚀

@ruiiiijiiiiang
Copy link
Copy Markdown

ruiiiijiiiiang commented May 15, 2026

Much efficiency. Very performance. Yeet to prod! 🚀

@Samushel
Copy link
Copy Markdown

Samushel commented May 15, 2026

LGTM

@erffy
Copy link
Copy Markdown

erffy commented May 15, 2026

I'm going to touch grass. Keep working bro

@dyanikoglu
Copy link
Copy Markdown

dyanikoglu commented May 15, 2026

ship it

@ShadowEngineer
Copy link
Copy Markdown

ShadowEngineer commented May 15, 2026

Couple nits if you don't mind!

@CrownKingClown
Copy link
Copy Markdown

CrownKingClown commented May 15, 2026

LGTM

@ImTheShrub
Copy link
Copy Markdown

ImTheShrub commented May 15, 2026

LGTM 🚀

1 similar comment
@Jesperejohannsen
Copy link
Copy Markdown

Jesperejohannsen commented May 15, 2026

LGTM 🚀

@jaredyankee
Copy link
Copy Markdown

jaredyankee commented May 15, 2026

lgtm

@Kowalskiexe
Copy link
Copy Markdown

Kowalskiexe commented May 18, 2026

LGTM

@marcossesh
Copy link
Copy Markdown

marcossesh commented May 18, 2026

LET'S GO, LGTM!!🔥

StanleyMasinde
StanleyMasinde approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown

@StanleyMasinde StanleyMasinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you.

RazinShafayet2007
RazinShafayet2007 approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown

@RazinShafayet2007 RazinShafayet2007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winteryanis
Copy link
Copy Markdown

winteryanis commented May 18, 2026

LGTM

@sanctusMarculus
Copy link
Copy Markdown

sanctusMarculus commented May 18, 2026

LGTM!

@speedskater1610
Copy link
Copy Markdown

speedskater1610 commented May 18, 2026

yo line 242,134 causes a memory leak can we put this through claude pls otherwise lgtm

Are you sure mythos said it looks GTM

@swordman08
Copy link
Copy Markdown

swordman08 commented May 18, 2026

I ran out of tokens about half way through review, I am going to go ahead and vibe approve the rest of the code, on the basis of vibes alone. I have put in a word of recommendation for your promotion.

mecies
mecies approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown

@mecies mecies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay-ish but do it faster and make no mistakes

@Faiaz98
Copy link
Copy Markdown

Faiaz98 commented May 18, 2026

LGTM

@sag1v
Copy link
Copy Markdown

sag1v commented May 18, 2026

Which model was used? It might not need a review at all.

@Ardakilic
Copy link
Copy Markdown

Ardakilic commented May 18, 2026

image

@Ashbborn
Copy link
Copy Markdown

Ashbborn commented May 18, 2026

LGTM, just fix the bug in line 242,134 and we good

@locainin
Copy link
Copy Markdown

locainin commented May 18, 2026

LGTM

DennisMagaki
DennisMagaki reviewed May 18, 2026
View reviewed changes
Copy link
Copy Markdown

@DennisMagaki DennisMagaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@7TIN
Copy link
Copy Markdown

7TIN commented May 18, 2026

LGTM, I reviewed all the code It took me 3 days.

@jose-alves-figueiroa
Copy link
Copy Markdown

jose-alves-figueiroa commented May 18, 2026

LGTM \o/

ddklein
ddklein approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown

@ddklein ddklein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Dannfonseca
Copy link
Copy Markdown

Dannfonseca commented May 18, 2026

LGTM!

@RenGeng
Copy link
Copy Markdown

RenGeng commented May 18, 2026

@claude what do you think ?

@lets-build-an-ocean
Copy link
Copy Markdown

lets-build-an-ocean commented May 18, 2026

Thats fine

@Ardakilic
Copy link
Copy Markdown

Ardakilic commented May 18, 2026

@coderabbitai review

@huyhoan1109
Copy link
Copy Markdown

huyhoan1109 commented May 18, 2026

Next step, rewrite all in binary :))

@jmarellanes
Copy link
Copy Markdown

jmarellanes commented May 18, 2026

This is absolute peak Gigachad.

@sweatybreeze
Copy link
Copy Markdown

sweatybreeze commented May 18, 2026

Incredible

@DaniloGhost
Copy link
Copy Markdown

DaniloGhost commented May 18, 2026

you have conflicts

Krentin018
Krentin018 approved these changes May 18, 2026
View reviewed changes
Copy link
Copy Markdown

@Krentin018 Krentin018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

66 more reviewers

@joaomcarlos joaomcarlos joaomcarlos left review comments

@mishalzaman mishalzaman mishalzaman left review comments

@qmogh qmogh qmogh left review comments

@Lyroth001 Lyroth001 Lyroth001 left review comments

@DennisMagaki DennisMagaki DennisMagaki left review comments

@sharktide sharktide sharktide requested changes

@MayakoAelys MayakoAelys MayakoAelys approved these changes

@lexlog lexlog lexlog approved these changes

@txssu txssu txssu approved these changes

@LMojica LMojica LMojica approved these changes

@liliarose liliarose liliarose approved these changes

@Krentin018 Krentin018 Krentin018 approved these changes

@outranker outranker outranker approved these changes

@lineargraph lineargraph lineargraph approved these changes

@sowa705 sowa705 sowa705 approved these changes

@cosmii02 cosmii02 cosmii02 approved these changes

@ImSkully ImSkully ImSkully approved these changes

@veeso veeso veeso approved these changes

@NNazem NNazem NNazem approved these changes

@TymanWasTaken TymanWasTaken TymanWasTaken approved these changes

@alexisdrakopoulos alexisdrakopoulos alexisdrakopoulos approved these changes

@setanjan123 setanjan123 setanjan123 approved these changes

@StanleyMasinde StanleyMasinde StanleyMasinde approved these changes

@EngBett EngBett EngBett approved these changes

@edenchazard edenchazard edenchazard approved these changes

@RainVaporeon RainVaporeon RainVaporeon approved these changes

@mecies mecies mecies approved these changes

@Luchsius Luchsius Luchsius approved these changes

@sanchpet sanchpet sanchpet approved these changes

@danblackadder danblackadder danblackadder approved these changes

@svetkomir svetkomir svetkomir approved these changes

@m-m-adams m-m-adams m-m-adams approved these changes

@StreakyFly StreakyFly StreakyFly approved these changes

@estnml estnml estnml approved these changes

@SimonTrep SimonTrep SimonTrep approved these changes

@Antipath1 Antipath1 Antipath1 approved these changes

@Jesperejohannsen Jesperejohannsen Jesperejohannsen approved these changes

@Cubicake Cubicake Cubicake approved these changes

@pnv28 pnv28 pnv28 approved these changes

@SleepyStew SleepyStew SleepyStew approved these changes

@Not-A-Normal-Robot Not-A-Normal-Robot Not-A-Normal-Robot approved these changes

@lmBored lmBored lmBored approved these changes

@Adstar123 Adstar123 Adstar123 approved these changes

@EDM115 EDM115 EDM115 approved these changes

@Sploder-Saptarshi Sploder-Saptarshi Sploder-Saptarshi approved these changes

@gokhanmeteerturk gokhanmeteerturk gokhanmeteerturk approved these changes

@es-sai-fi es-sai-fi es-sai-fi approved these changes

@OmkarJS OmkarJS OmkarJS approved these changes

@cyruskelly cyruskelly cyruskelly approved these changes

@Mellurboo Mellurboo Mellurboo approved these changes

@eggy03 eggy03 eggy03 approved these changes

@anbguye anbguye anbguye approved these changes

@SaranshBangar SaranshBangar SaranshBangar approved these changes

@greeenboi greeenboi greeenboi approved these changes

@ddklein ddklein ddklein approved these changes

@My-Bad-2 My-Bad-2 My-Bad-2 approved these changes

@erffy erffy erffy approved these changes

@VegaBits VegaBits VegaBits approved these changes

@kasi-otter kasi-otter kasi-otter approved these changes

@YO-WHATS-UP2 YO-WHATS-UP2 YO-WHATS-UP2 approved these changes

@dinesh-git17 dinesh-git17 dinesh-git17 approved these changes

@speedskater1610 speedskater1610 speedskater1610 approved these changes

@RazinShafayet2007 RazinShafayet2007 RazinShafayet2007 approved these changes

@ilnarildarovuch2 ilnarildarovuch2 ilnarildarovuch2 approved these changes

@gdabu-maven gdabu-maven gdabu-maven approved these changes

@bobagent37 bobagent37 bobagent37 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.