IPC4: Remove from handler-kernel.c function ipc4_get_pipeline_data()#10705
Open
singalsu wants to merge 1 commit intothesofproject:mainfrom
Open
IPC4: Remove from handler-kernel.c function ipc4_get_pipeline_data()#10705singalsu wants to merge 1 commit intothesofproject:mainfrom
singalsu wants to merge 1 commit intothesofproject:mainfrom
Conversation
The function is unused and with xt-clang toolchain and warnings treated as errors this fails the xt-testbench4 build. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
dbaluta,
kv2019i,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused helper from the IPC4 kernel handler to avoid -Wunused-function build failures when using the xt-clang toolchain with warnings treated as errors (notably in xt-testbench4 builds).
Changes:
- Delete the unused
static inlinefunctionipc4_get_pipeline_data()fromhandler-kernel.c.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lyakh
approved these changes
Apr 16, 2026
Collaborator
lyakh
left a comment
lyakh
left a comment
There was a problem hiding this comment.
oh, that's a handler.c splitting artifact - we now have 2 copies of this function - one in handler-user.c and one in handler-kernel.c, and only the former is used...
kv2019i
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The function is unused and with xt-clang toolchain and warnings treated as errors this fails the xt-testbench4 build.