ASoC: SOF: ipc4-control: pass data pointer and size as function argum…#5736
Draft
kv2019i wants to merge 1 commit intothesofproject:topic/sof-devfrom
Draft
ASoC: SOF: ipc4-control: pass data pointer and size as function argum…#5736kv2019i wants to merge 1 commit intothesofproject:topic/sof-devfrom
kv2019i wants to merge 1 commit intothesofproject:topic/sof-devfrom
Conversation
…ents Move the data_ptr and data_size assignments into sof_ipc4_set_get_kcontrol_data() as explicit function parameters instead of having each caller set and clear them on the shared cdata->msg before and after the call. Link: thesofproject#5734 Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Collaborator
Author
|
@bardliao @ujfalusi There's a potential race condition in sof_ipc4_set_get_kcontrol_data(). The shared cdata->msg structure's data_ptr/data_size fields are set by callers before acquiring setup_mutex, and cleared after the IPC call returns. I couldn't reproduce yet, but if @bardliao you can try out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ents
Move the data_ptr and data_size assignments into
sof_ipc4_set_get_kcontrol_data() as explicit function parameters instead of having each caller set and clear them on the shared cdata->msg before and after the call.
Link: #5734