Complete weapon-wheel time-scale CI integration - #142
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a8ab71d7a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| smooth_slow_time = function_body( | ||
| common, "static bool openQ4_ShouldUseSmoothSingleplayerSlowTime( void )" | ||
| common, | ||
| "static bool openQ4_ShouldUseSmoothSingleplayerSlowTime( float effectiveTimeScale )", |
There was a problem hiding this comment.
Changing only this expected signature leaves validate_async_module_state() in tools/tests/game_type_module_selection.py searching for the old ( void ) declaration at line 834. The commit-validation workflow runs that script, which now raises ValueError: substring not found before completing; update that duplicate contract to recognize the parameterized helper as part of this change.
Useful? React with 👍 / 👎.
| require( | ||
| smooth_slow_time, | ||
| "return effectiveTimeScale < 0.999f;", | ||
| "Composed single-player slow-time detection", |
There was a problem hiding this comment.
Inspecting only the helper body does not enforce the new composed-scale contract: changing Async() to call this helper with com_timescale.GetFloat() while retaining the separate timescale assignment would satisfy both this assertion and weapon_wheel_time_scale.py, but transient weapon-wheel slowdown would take the non-smooth branch and reduce async tick cadence. Also assert within Async() that the composed timescale value is passed to the helper.
Useful? React with 👍 / 👎.
themuffinator
changed the title
1 participant
Completes the cross-repository integration for PR 141. It updates stale slow-time regression signatures, pins both engine workflows to the merged modernization GameLib API 46 revision from openQ4-game PR 10, and advances every affected API contract. Validation includes full Windows x64 GameLib and engine builds plus the time-scale, game-module selection, level-cache, MVD, renderer, network, staging, allocator, and shared-header alignment tests.