Preserve user time and movement CVars - #141
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88c54904f9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| require(run_frame, "cvarSystem->GetCVarFloat( \"timescale\" ) * common->GetGameTimeScale()", "SP simulation scale") | ||
|
|
||
| game_api = read(GAME_ROOT / "src/game/Game.h") | ||
| require(game_api, "const int GAME_API_VERSION\t\t= 44;", "updated engine/GameLib ABI") |
There was a problem hiding this comment.
When either checked-in validation workflow runs this new test, it checks out the companion revision explicitly documented as implementing GAME_API_VERSION 45, while this assertion requires version 44; existing tests such as game_type_module_selection.py and renderer_temporal_presentation.py also require 45. Consequently, no normal Game.h can satisfy the full validation suite, so every PR and push fails here. Update the companion pin and all ABI assertions coherently—using a new ABI version if the added virtual methods require it—rather than uniquely expecting 44 in this test.
AGENTS.md reference: AGENTS.md:L26-L27
Useful? React with 👍 / 👎.
1 participant
Summary
Validation