Skip to content

Fix community-reported menu, font, version, and dmap issues - #140

Merged
themuffinator merged 1 commit into
mainfrom
codex/community-reports-20260827
Aug 27, 2026
Merged

Fix community-reported menu, font, version, and dmap issues#140
themuffinator merged 1 commit into
mainfrom
codex/community-reports-20260827

Conversation

@themuffinator

Copy link
Copy Markdown
Owner

Summary

  • keep SP pause-menu activation off save, mod, device, display, binding, and MP-model enumeration paths; refresh each catalog on its destination page and precache all first-use menu media during level loading
  • select bitmap font atlases using the final viewport enlargement so 1080p, 1440p, and 4K text no longer magnifies a low-resolution source atlas
  • regenerate Git-derived version metadata on every build invocation while preserving no-op incremental builds when the identity is unchanged
  • resolve editable func_group entities before dmap geometry processing, matching the retail Quake 4 compiler and fixing the hangar1 false leak reported in discussion #124

Validation

  • tools/build/meson_setup.ps1 compile -C builddir
  • tools/build/meson_setup.ps1 install -C builddir --no-rebuild --skip-subprojects
  • python tools/validation/openq4_validate.py push --skip-build --game-libs-repo <modernization-worktree> (passed in 189.4s)
  • staged SP game/airdefense2: gameplay entered, pause menu activated in 12ms against a 50ms bound, with no late menu-material or menu-sound load
  • staged uiFontParitySelfTest and high-resolution engine screenshot validation
  • unchanged official game/hangar1.map: openQ4 now matches the retail compiler's 7,632 world brushes, 6,739 world trisurfs, 8,217 patches, and 1,415 entities, with no leak
  • a second unchanged build regenerated the lightweight metadata target without recompiling the binaries; the runtime banner reported the new clean commit SHA without Meson reconfiguration

Community context

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 672bbe9a56

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread meson.build
Comment on lines +140 to +146
generated_version_header = custom_target(
'openq4_version_generated',
output: 'openq4_version_generated.h',
command: version_metadata_command + ['--header-out', '@OUTPUT@'],
depend_files: files('tools/build/openq4_version.py'),
build_always_stale: true,
build_by_default: true,

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Refresh configured metadata with the version header

On an existing Linux build directory, this target updates the generated header after a commit or dirty-state change, so the rebuilt binaries report the new identity, but assets/linux/openq4.desktop.in and the Steam Deck entry are still produced by configure-time configure_file() calls using the old openq4_version_full value at meson.build:1874-1893. The same partial refresh can leave content/baseoq4/mod.json stale when a newer release tag changes the resolved base version. Regenerate these version-bearing configured artifacts from the build-time metadata as well, or the staged package can contain mutually inconsistent version identities until Meson is manually reconfigured.

AGENTS.md reference: AGENTS.md:L60-L60

Useful? React with 👍 / 👎.

@themuffinator
themuffinator merged commit 1c22b20 into main Aug 27, 2026
21 of 25 checks passed
@themuffinator
themuffinator deleted the codex/community-reports-20260827 branch August 27, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant