Advance and document the v0.10 save compatibility repair - #139
Conversation
4869657 to
47b33df
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 48696572a7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sp_pre_liquid_snapshots = snapshot_tuples( | ||
| sp, "OPENQ4_SAVEGAME_V3_PRE_PLAYER_LIQUID_FIELDS_SNAPSHOTS" | ||
| ) |
There was a problem hiding this comment.
Advance the pinned GameLibs revision with this contract
The added check requires symbols introduced by the companion decoder change, but the checked commit-validation.yml and push-verification.yml still fetch openQ4-game revision 79c9d7d1e26952ffd8e5352f7d51b64ee08b9d82 before invoking this script. That older pinned source does not contain OPENQ4_SAVEGAME_V3_PRE_PLAYER_LIQUID_FIELDS_SNAPSHOTS, so snapshot_tuples() raises Missing snapshot array and makes the standard PR and push validation jobs fail. Advance both workflow pins to the companion revision containing the decoder as part of this cross-repository change.
AGENTS.md reference: AGENTS.md:L26-L27
Useful? React with 👍 / 👎.
47b33df to
8aa4742
Compare
|
Final validation is complete.
The four failures in the push-only macOS runtime-smoke matrix exactly match the four failures on current |
Summary
09fa7e175efa5a5d819569ba577fd0e11c38a891Validation
python tools/tests/competitive_match_layer.pypython tools/tests/savegame_v3_contract.pypython tools/tests/savegame_pointer_width_safety.pypython tools/tests/gamelibs_staging.pypython tools/tests/validation_hardening.pypython tools/tests/docs_link_integrity.pypython tools/tests/release_tooling_safety.pypython -m py_compile tools/tests/savegame_v3_contract.pypython tools/validation/openq4_validate.py pr --dry-run --game-libs-repo E:\Repositories\openQ4-gamegit diff --checkRuntime evidence
ReadTraceoffset, before reaching the missing-mod GUI boundary; combined-modernization log SHA-256CED470F16CD82A20453B9B5B276C1A0C453274803F9B5BF1E511D720D1D3E3CAgame/airdefense2save/reload completes in active gameplay and exits normally; save SHA-2569B3F94F1FAAC72F05C791DD7A253E980765A343FF4E1481EDD9D7D09A9C9015D, reload log SHA-2562EACB7D643E01EC66F1180E3678AFA3F21E5CB5308B812FFD4DD1292D60CA31B, engine screenshot SHA-256600D2E29DBCBE4C826CA11A686E0D04028E0FD06B87BAF236C16F5F7175EB74AThe exact attached mod save next reaches a GUI identity mismatch because the attachment omits its HiDef mod GUI/assets. Issue #123 will remain open for reporter-side confirmation with the complete mod installation.
Related to #123.