Parse generated AAS 1.08 face settings - #138
Merged
Merged
Conversation
|
man you are fast |
Owner
Author
|
Final validation is complete:
The four push-workflow macOS smoke failures are the already-documented hosted-runner OpenGL 2 compatibility limitation inherited unchanged from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generateAllFacessetting already emitted by openQ4's writerFixes #137.
Investigation
The archive supplied in #123 (SHA-256
CED6E9D92E67D8FF71E1F2E93B68D7F6DD7C961D7E759E90E3AA243408AED187) contains.aas32,.aas48,.aas96,.aas128, and.aas250files that all carrygenerateAllFaces = 0. openQ4's writer emits that key, butidAASSettings::FromParserhandled only the neighboringgenerateTacticalFeatureskey. This produced three warnings per file while leaving the face flag uninitialized.Validation
python tools/tests/aas_settings_contract.pypython tools/tests/docs_link_integrity.pypython tools/tests/release_tooling_safety.pytools/build/meson_setup.ps1 compile -C builddir(Windows x64 client, dedicated, SP, MP, OpenGL, Vulkan)git diff --check.map,.proc,.cm, and five AAS files from an isolated loose pathgenerateAllFaces/invalid-token, stale-AAS, navigation-load, engine error, or fatal diagnosticE62BD7DE995E16D31890CE9E44625FB829B20541DD7B7CB31729251214548F3874E5C6775C75CEA391E9E6D9E16443A026EFFAFDAC9291072F2966F50A73B196