Restore SDL context before VSync updates - #135
Merged
Merged
Conversation
Owner
Author
|
Native Wayland runtime evidence is now available from the Clang/no-libdecor commit job in run I downloaded
This directly exercises native SDL Wayland under Mesa llvmpipe and confirms the initialization failure observed during #89 investigation is gone on this CI path. The wider real-hardware performance question in #89 remains open separately. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
r_swapIntervaledits through the existing helperInvestigation
A native SDL Wayland run performed while investigating #89 logged:
The initial window-parameter application may leave SDL's GL context detached before startup applies VSync.
GLimp_SetScreenParmsalready repairs the context on its own path, butSDL3_ApplySwapIntervalis also called directly during startup and live cvar handling. Moving the guard into that central helper makes every caller safe and leaves the existing error/accounting path intact.This corrects a concrete initialization error found during #89 investigation. It does not close #89: the reporter's CachyOS/RTX 3070 performance trace is still needed for the broader settings-panel claim.
Validation
python tools/tests/linux_vsync_support.pypython tools/tests/macos_sdl3_backend_guard.pypython tools/tests/linux_sdl3_glew_loader.pypython tools/tests/sdl3_multidisplay_windowing.pytools/build/meson_setup.ps1 compile -C builddir renderer-gl_x64python -m py_compile tools/tests/linux_vsync_support.py tools/tests/macos_sdl3_backend_guard.pygit diff --check origin/main...HEADNo external code was incorporated.
Related: #89