Skip to content

Restore configurable texture filtering - #130

Merged
themuffinator merged 1 commit into
mainfrom
codex/add-texture-filter-control-121
Aug 26, 2026
Merged

Restore configurable texture filtering#130
themuffinator merged 1 commit into
mainfrom
codex/add-texture-filter-control-121

Conversation

@themuffinator

Copy link
Copy Markdown
Owner

Fixes #121.

What changed

  • restores the archived image_filter renderer CVar with all six Quake 4 filter names and console completion
  • applies the selected TF_DEFAULT sampling mode in both OpenGL and Vulkan
  • refreshes loaded default samplers immediately when image_filter or image_anisotropy changes
  • keeps explicitly authored sampler states intact and disables anisotropy for nearest-texel modes
  • documents the pixelated-texture command and adds a validation contract

Validation

  • python tools/tests/renderer_texture_filter.py
  • full Windows x64 Meson compile, including client, dedicated server, SP/MP modules, renderer-gl, and renderer-vk
  • windowed SP game/airdefense1 gameplay through renderer_gameplay_benchmark.py, with image_filter=GL_NEAREST_MIPMAP_NEAREST: 1/1 pass, live sampler refresh logged, engine-render-target screenshot captured
  • git diff --check

The broader settings_menu_coverage.py check is currently blocked in this workspace by the companion openQ4-game main checkout lacking its expected MP net_menulanserver declaration; that pre-existing repository-alignment failure is unrelated to these renderer changes.

@themuffinator themuffinator mentioned this pull request Aug 26, 2026
@themuffinator
themuffinator merged commit 4610616 into main Aug 26, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ed4195d672

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

vkSamplerKeys[ vkNumSamplers ].repeat = repeat;
vkSamplerKeys[ vkNumSamplers ].mips = mips;
vkSamplerKeys[ vkNumSamplers ].anisotropy = anisotropy;
vkSamplerKeys[ vkNumSamplers ].defaultFilterMode = defaultFilterMode;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reclaim stale Vulkan samplers when settings change

When Vulkan users repeatedly switch image_filter or adjust image_anisotropy, each mode/anisotropy/repeat/mip combination is retained until device shutdown because the new mode is part of the cache key. Refreshing all loaded default-filter images can therefore consume the fixed 64-entry cache during a normal session; subsequent misses return vkSamplers[0], applying an unrelated filter or address mode to textures. Evict stale default samplers or otherwise bound/reuse these setting-dependent entries.

Useful? React with 👍 / 👎.

@themuffinator
themuffinator deleted the codex/add-texture-filter-control-121 branch August 27, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Texture filtering

1 participant