Skip to content

Trvae update to 1.1.2#136

Open
LuckyMD wants to merge 6 commits into
mainfrom
trvae_update
Open

Trvae update to 1.1.2#136
LuckyMD wants to merge 6 commits into
mainfrom
trvae_update

Conversation

@LuckyMD

@LuckyMD LuckyMD commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

This PR updates the trVAE function to work with version 1.1.2

To do:

  • update env
  • test locally
  • test on snakemake

@LuckyMD

LuckyMD commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator Author

@M0hammadL please check if this looks correct to you!

@M0hammadL

M0hammadL commented Aug 4, 2020

Copy link
Copy Markdown

THIS line has to change to :
conditions = adata.obs[batch].unique().tolist() and then pass :

network = trvae.models.trVAE(x_dimension=adata.shape[1],
                                 architecture=[256,64],
                                 z_dimension=10,
                                 gene_names=adata.var_names.tolist(),
                                 conditions=conditions,
                                 model_path='/localscratch/',
                                 alpha=0.0001,
                                 beta=50,
                                 eta=100,
                                 loss_fn='sse',
                                 output_activation='linear')

@LuckyMD

LuckyMD commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator Author

I see, so you have to pass a list of the batches rather than the name of the batch covariate. Thanks!

@LuckyMD

LuckyMD commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator Author

THIS line has to change to :
conditions = adata.obs[batch].unique().tolist() and then pass :

network = trvae.models.trVAE(x_dimension=adata.shape[1],
                                 architecture=[256,64],
                                 z_dimension=10,
                                 gene_names=adata.var_names.tolist(),
                                 conditions=conditions,
                                 model_path='/localscratch/',
                                 alpha=0.0001,
                                 beta=50,
                                 eta=100,
                                 loss_fn='sse',
                                 output_activation='linear')

@M0hammadL addressed with commit c92622a . All good now?

@LuckyMD LuckyMD mentioned this pull request Sep 11, 2020
@ilibarra

ilibarra commented Dec 2, 2020

Copy link
Copy Markdown

@LuckyMD: What is the current status on running trVAE using scIB with snakemake? Would the latest trVAE version (1.1.2) work with the latest version of the scIB git? Maybe handled in another issue and overlooked it.

Thanks!

@LuckyMD

LuckyMD commented Dec 2, 2020

Copy link
Copy Markdown
Collaborator Author

trVAE from version 1.0 will only work with this PR, which we haven't merged yet, as it didn't pass initial testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants