Fix Foreman legacy UI erroring out#92
Merged
Merged
Conversation
Member
|
In #94 I'm adding it to the modern UI instead, but it's still lacking actions. |
Member
|
I would support fixing this as long as modern UI is not implemented. This seems to be a quick fix for now. |
Member
|
There's a merge conflict, so please rebase. |
ananace
force-pushed
the
fix-legacy-ui
branch
3 times, most recently
from
May 17, 2024 13:49
3653261 to
56833bb
Compare
Member
|
@dgoetz do you mind having a look? I would also purpose a new release after that because the current plugin version is broken on multiple parts. I could take care of packaging PRs |
ekohl
reviewed
May 28, 2024
Co-authored-by: Ewoud Kohl van Wijngaarden <ewoud@kohlvanwijngaarden.nl>
This reverts commit 26da44b.
Member
|
Thanks, @ananace. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #90