Skip to content

[WIP] parser: framework started - #28

Draft
pinecat wants to merge 5 commits into
masterfrom
parser
Draft

[WIP] parser: framework started#28
pinecat wants to merge 5 commits into
masterfrom
parser

Conversation

@pinecat

@pinecat pinecat commented Mar 6, 2021

Copy link
Copy Markdown
Collaborator

Getting down the general framework for the parser. The parser will
parse out a bot command into a multinode tree, with the root of the tree
being the most top-level command, and the most left leaf node being the
deepest (sub) command.

Getting down the general framework for the parser.  The parser will
parse out a bot command into a multinode tree, with the root of the tree
being the most top-level command, and the most left leaf node being the
deepest (sub) command.
@pinecat pinecat self-assigned this Mar 6, 2021
@pinecat
pinecat marked this pull request as draft March 6, 2021 05:14
@pinecat pinecat linked an issue Mar 6, 2021 that may be closed by this pull request
@codecov-io

codecov-io commented Mar 6, 2021

Copy link
Copy Markdown

Codecov Report

Merging #28 (81fd0e2) into master (f4546a8) will decrease coverage by 0.29%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   21.27%   20.97%   -0.30%     
==========================================
  Files          10       10              
  Lines         282      286       +4     
==========================================
  Hits           60       60              
- Misses        218      222       +4     
  Partials        4        4              
Impacted Files Coverage Δ
pkg/cmd/context.go 0.00% <ø> (ø)
pkg/cmd/router.go 10.84% <0.00%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4546a8...81fd0e2. Read the comment docs.

pinecat added 4 commits March 7, 2021 19:18
Added ability to pass in more than one string delimeter to the parser.
You can also pass in brackets as 2 character string delims such as angle
brackets ("<>") or square brackets ("[]").
Moved the parser package to pkg, as it cleans up/removes invalid import
cycles.
Started adding framework for the lexer.  I believe that a larger
rewrite/re-organizing of the cmd/commands framework may be in order, as
I keep running into import cycle errors.
Removing unfinished function in lexer to not break the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature: Better command parsing

2 participants