gcs: support custom GCS API endpoint via endpoint config option - #270
Open
HarnageaGabriel wants to merge 1 commit into
Open
gcs: support custom GCS API endpoint via endpoint config option#270HarnageaGabriel wants to merge 1 commit into
HarnageaGabriel wants to merge 1 commit into
Conversation
Adds an Endpoint field to gcs.Config, wired via option.WithEndpoint() for both the HTTP and gRPC client paths. Enables use of GCP regional endpoints (https://cloud.google.com/storage/docs/regional-endpoints). Left empty by default so behavior is unchanged. For thanos-io/thanos#7862.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Endpointfield togcs.Config, wired viaoption.WithEndpoint()for both the HTTP and gRPC client construction paths inproviders/gcs/gcs.go.""), so existing behavior and default GCS endpoint resolution are unchanged — fully backward compatible.Fixes thanos-io/thanos#7862.
Test plan
go build ./...go test ./providers/gcs/...(11 passed, including newTestParseConfig_Endpoint)go vet ./providers/gcs/...