feat(HTTPConfig): expose config to force-attempt HTTP/2 - #266
Merged
GiedriusS merged 2 commits intoAug 17, 2026
Merged
Conversation
Signed-off-by: francoposa <franco@francoposa.io>
francoposa
force-pushed
the
francoposa/expose-config-force-attempt-http2
branch
from
July 30, 2026 20:41
fd905e2 to
aaf0154
Compare
francoposa
marked this pull request as ready for review
July 30, 2026 21:00
francoposa
force-pushed
the
francoposa/expose-config-force-attempt-http2
branch
from
August 14, 2026 17:32
1e2870b to
44bf504
Compare
4 tasks
francoposa
added a commit
to grafana/mimir
that referenced
this pull request
Aug 15, 2026
… object storage clients (#16385) This option fixes extreme object storage tail latency in GCS due to GCS killing connections and the reconnect storm blocking the head of the line. Unfortunately this must from my personal fork for now because Thanos is unresponsive to PRs on `thanos-io/objstore` and the Grafana GitHub org has disabled any ability to effectively use public forks - the `grafana/objstore` fork is too far out of date and cannot be synced with upstream. Upstream PR is sitting at the same commit hash ([44bf504](thanos-io/objstore@44bf504)) - thanos-io/objstore#266 <!-- Thanks for sending a pull request! Before submitting: 1. Read our CONTRIBUTING.md guide 2. Rebase your PR if it gets out of sync with main --> #### What this PR does #### Which issue(s) this PR fixes or relates to Fixes #<issue number> #### Checklist - [ ] Tests updated. - [x] Documentation added. - [x] `CHANGELOG.md` updated - the order of entries should be `[CHANGE]`, `[FEATURE]`, `[ENHANCEMENT]`, `[BUGFIX]`. If changelog entry is not needed, please add the `changelog-not-needed` label to the PR. - [ ] [`about-versioning.md`](https://github.com/grafana/mimir/blob/main/docs/sources/mimir/configure/about-versioning.md) updated with experimental features.
GiedriusS
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Added flag to pass through
ForceAttemptHTTP2- we are experiencing extremely high tail latencies with GCS that can be mitigated in part by HTTP/2, at least in our benchmarks so far.This deals with the Go
http.Transport's design choice of silently downgrading to HTTP/1.1 when a customTransportis used:Verification
Test are added for config parsing & validation - we verified the performance difference in a benchmark here where we just hardcoded the flag in
objstore/exthttp/transport.go.