s3: tidy up transport construction - #265
Open
bboreham wants to merge 1 commit into
Open
Conversation
Only build the default transport if none is set in config. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
JoaoBraveCoding
left a comment
JoaoBraveCoding
left a comment
Collaborator
There was a problem hiding this comment.
Personally I tend to prefer the default & overwrite approach vs using else as it makes the code easier to read/maintain. From my POV I would rather see the comment change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Only build the default transport if none is set in config.
This is what the comment already said; it confused me that the code was doing extra work.
Verification
It's simple enough to eyeball. Hopefully there are tests.