This repository was archived by the owner on May 3, 2026. It is now read-only.
fix: safe JSON construction for Discord webhook notifications#4
Merged
Conversation
Agent-Logs-Url: https://github.com/th30d4y/0Commits/sessions/67b9076a-162b-4872-99ff-49ffe07dd37c Co-authored-by: 0x5t4l1n <161853795+0x5t4l1n@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
0x5t4l1n
May 3, 2026 06:42
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discord webhook calls were silently failing whenever commit messages or author names contained
",\, or newlines — all common in the auto-increment workflow — because those values were interpolated raw into a hand-built JSON string.Changes
jq -n --argso all field values are properly escaped regardless of contentCOMMIT_MESSAGEandAUTHORare now passed viaenv:instead of inline${{ }}expressions in the shell script, avoiding both shell and JSON injectioncurl -s→curl -sfso HTTP 4xx/5xx responses from Discord surface as step failures rather than silent no-ops