Conversation
Add PHPStan static analysis as a separate CI step before running tests. Also suppress new.static warnings in Type subclasses and update boolean return type hints from `boolean` to `bool` in phpdoc blocks.
…lass - Add `getErrorCode()` to expose the error code string directly - Add `getError()` to retrieve the previous Error instance from the chain - Update test to use new accessors instead of accessing raw exception internals
- Fix nullable type hints in Column and ExecutesQueries docblocks - Rename observer parameter to $_observer to satisfy PHPStan overload detection - Simplify return logic in EntityManager::observe using direct instanceof check - Add @phpstan-ignore-next-line for PDO\\Mysql class reference in DbConfig - Remove redundant array_values() call in Mysql bulk insert loop - Use getReference() accessor instead of direct property access in ManyToMany
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add PHPStan static analysis as a separate CI step before running tests. Also suppress new.static warnings in Type subclasses and update boolean return type hints from
booleantoboolin phpdoc blocks.