Skip to content

feat(angular): support ATL zoneless imports - #1367

Open
ThiloAschebrock wants to merge 1 commit into
testing-library:mainfrom
ThiloAschebrock:pr/recognize-zoneless-angular-imports
Open

feat(angular): support ATL zoneless imports#1367
ThiloAschebrock wants to merge 1 commit into
testing-library:mainfrom
ThiloAschebrock:pr/recognize-zoneless-angular-imports

Conversation

@ThiloAschebrock

Copy link
Copy Markdown

Checks

Changes

  • Enable all Angular rules for @testing-library/angular/zoneless

Context

Fixes #1366

Copilot AI review requested due to automatic review settings July 27, 2026 06:06

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Extends the plugin’s Testing Library module detection to recognize Angular Testing Library’s secondary zoneless entry point (@testing-library/angular/zoneless), ensuring Angular-specific rules don’t get skipped when users import from the zoneless module.

Changes:

  • Added @testing-library/angular/zoneless to the plugin’s canonical list of recognized Testing Library modules.
  • Updated module-detection unit tests to include the new Angular zoneless import.
  • Updated multiple rule test suites to treat the zoneless entry point as a supported Angular Testing Library import source.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/utils/index.ts Adds @testing-library/angular/zoneless to LIBRARY_MODULES so core module detection recognizes it.
tests/utils/is-testing-library-module.test.ts Extends module-detection test coverage to include the new zoneless import source.
tests/rules/await-async-queries.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/await-async-utils.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-await-sync-events.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-await-sync-queries.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-container.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-debugging-utils.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-node-access.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-promise-in-fire-event.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-render-in-lifecycle.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-test-id-queries.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-wait-for-multiple-assertions.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-wait-for-side-effects.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/no-wait-for-snapshot.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/prefer-find-by.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/prefer-query-by-disappearance.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/prefer-screen-queries.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.
tests/rules/render-result-naming-convention.test.ts Includes zoneless entry point in supported frameworks for rule test coverage.

@MichaelDeBoey MichaelDeBoey changed the title fix(angular): recognize zoneless Testing Library imports feat(angular): support ATL zoneless imports Jul 30, 2026
@MichaelDeBoey
MichaelDeBoey requested a review from Belco90 July 30, 2026 14:24
@codecov

codecov Bot commented Jul 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.35%. Comparing base (1deda22) to head (4b153ea).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1367   +/-   ##
=======================================
  Coverage   97.35%   97.35%           
=======================================
  Files          49       49           
  Lines        6020     6021    +1     
  Branches     1544     1544           
=======================================
+ Hits         5861     5862    +1     
  Misses        157      157           
  Partials        2        2           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Thilo Aschebrock <thilo.aschebrock@tngtech.com>
@MichaelDeBoey
MichaelDeBoey force-pushed the pr/recognize-zoneless-angular-imports branch from 82bdb5f to 4b153ea Compare August 2, 2026 20:37
Copilot AI review requested due to automatic review settings August 2, 2026 20:37

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rules don’t recognize @testing-library/angular/zoneless imports

3 participants