Skip to content

Enable using non-'static data in StaticSoundData #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tesselode merged 1 commit into from
Aug 26, 2026
Merged

Enable using non-'static data in StaticSoundData #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions crates/kira/src/sound/static_sound/data/from_file.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ impl StaticSoundData {

/// Loads a cursor wrapping audio file data into a [`StaticSoundData`].
#[cfg_attr(docsrs, doc(cfg(feature = "symphonia")))]
pub fn from_cursor<T: AsRef<[u8]> + Send + Sync + 'static>(
pub fn from_cursor<T: AsRef<[u8]> + Send + Sync>(
cursor: Cursor<T>,
) -> Result<StaticSoundData, FromFileError> {
Self::from_media_source(cursor)
Expand All @@ -28,13 +28,13 @@ impl StaticSoundData {
/// Loads an audio file from a type that implements Symphonia's [`MediaSource`]
/// trait.
#[cfg_attr(docsrs, doc(cfg(feature = "symphonia")))]
pub fn from_media_source(
media_source: impl MediaSource + 'static,
) -> Result<Self, FromFileError> {
pub fn from_media_source(media_source: impl MediaSource) -> Result<Self, FromFileError> {
Self::from_boxed_media_source(Box::new(media_source))
}

fn from_boxed_media_source(media_source: Box<dyn MediaSource>) -> Result<Self, FromFileError> {
fn from_boxed_media_source(
media_source: Box<dyn MediaSource + '_>,
) -> Result<Self, FromFileError> {
let codecs = symphonia::default::get_codecs();
let probe = symphonia::default::get_probe();
let mss = MediaSourceStream::new(media_source, Default::default());
Expand Down
Loading