fix(reconcile): skip unsafe journals - #68
Merged
Merged
Conversation
A completed journal from an older plan format can fail current path validation. Filter those journals before maintenance so one stale record cannot block the live inventory scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes LIVE SCAN falling back to demo data when a verified historical journal references an Agent root that is no longer configured. Journal validation now filters unsafe historical records at the shared
verifiedJournals()boundary, preserving their files while preventing maintenance from aborting.Key Changes
Verification & Testing
yarn test electron/skill-reconciler.test.ts— 17 passedJournal path is outside the configured roots; local signed reinstall and LIVE SCAN verification will follow mergeImpact & Risk
Unsafe historical journals are ignored rather than exposed through Activity or maintenance. No journal files are deleted and no database migrations or environment variables are required.