Add adaptive TCI interpolation for partitioned tensor trains#562
Open
SamuelBadr wants to merge 2 commits into
Open
Add adaptive TCI interpolation for partitioned tensor trains#562SamuelBadr wants to merge 2 commits into
SamuelBadr wants to merge 2 commits into
Conversation
shinaoka
requested changes
Jul 24, 2026
shinaoka
left a comment
Member
There was a problem hiding this comment.
I found a few blocking issues before this should merge. The main correctness problem is that adaptive patch acceptance currently ignores TCI2's full convergence criterion, and there are also repository-rule gaps around checked arithmetic and structured-copy testing. I did not complete local test execution because it was interrupted, so these comments are based on static review of the PR diff and repository rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tensor4all_partitionedtt::adaptiveinterpolateandAdaptiveInterpolateOptionsValidation
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --release --workspacecargo test --doc --release --workspacecargo doc --workspace --no-deps(passes; pre-existing rustdoc warnings remain)cargo run -p api-dump --release -- . -o docs/apicargo nextestandmdbookare not installed in the local environment, socargo nextest run --release --workspaceand./scripts/test-mdbook.shcould not run locally. The full releasecargo test --workspacefallback passed.Provenance
The patch queue and pivot-recycling structure are derived from TCIAlgorithms.jl commit
e501032278c9dd41b46c5851d8238169c8d178c5under MIT. The upstream notice is retained incrates/tensor4all-partitionedtt/LICENSE-TCIALGORITHMS-MIT.