Skip to content

Validate client credential type - #99

Open
cryptoryda wants to merge 3 commits into
tempoxyz:mainfrom
cryptoryda:validate-client-credential-type
Open

Validate client credential type#99
cryptoryda wants to merge 3 commits into
tempoxyz:mainfrom
cryptoryda:validate-client-credential-type

Conversation

@cryptoryda

Copy link
Copy Markdown
Contributor

Reject unsupported Tempo client credential types

Summary

  • validate Config.CredentialType in chargeclient.New
  • preserve the empty value as the existing transaction default
  • add regression coverage for an unsupported value

Why

Unknown credential types previously survived construction and could be
silently serialized as transaction credentials. Failing at construction makes
configuration mistakes explicit and prevents unintended credential behavior.

Testing

go test ./pkg/tempo/client
go test ./...
go vet ./...

@brendanjryan

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Swish!

Reviewed commit: fe0e95e729

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants