-
Notifications
You must be signed in to change notification settings - Fork 322
Clarifying workflow ID consistency and HA #4794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lukeknep
wants to merge
13
commits into
main
Choose a base branch
from
workflowid-ha-clarification
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
317bfd7
Clarifying workflow ID consistency and HA
lukeknep 34f95b5
Apply review feedback: caution admonition for RPO data loss
lukeknep 4aa3276
Simplify note on Workflow Id uniqueness
lukeknep 6ff7dfe
Refine manual failover explanation in documentation
lukeknep 1ca47e4
Update caution note on data loss during failovers
lukeknep 111be20
Update failover documentation for clarity
lukeknep 81fe9a8
Update failover section for Workflow execution semantics
lukeknep 25259e0
Update conflict resolution section for clarity
lukeknep 383afbc
Add section explaining how Workflow Id uniqueness survives forced fai…
lukeknep f1785c1
Trim redundant clause from steady-state uniqueness note
lukeknep d84dd88
Simplify divergence condition in uniqueness note
lukeknep f58c302
Remove durability-vs-uniqueness caveat sentence
lukeknep 7794a2e
Address review feedback on conflict resolution and Workflow Id unique…
lukeknep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@temporal-nick can you check for correctness?