Support Prompt Option#35
Open
LarzP123 wants to merge 2 commits into
Open
Conversation
Author
|
@tekul Could you review? Or is there a way that you'd prefer I get a review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This adds support for 3.1.2.1. Authentication Request options. Which means that you can now have headers with
prompt=set tonone,login,consent, orselect_account.Details
The handling for select_account was more complicated and came in a different commit. The updates there were
Testing
the password for all of these users is "cat"
http://localhost:3000/oauth/authorize?client_id=testclient&response_type=code&scope=openid&redirect_uri=https://httpbin.org/get&state=abc123&prompt=nonein a web browser. You should be given the error 'interaction_required'
http://localhost:3000/oauth/authorize?client_id=testclient&response_type=code&scope=openid&redirect_uri=https://httpbin.org/get&state=abc123You should be taken to log in. Log in as us:catps:cathttp://localhost:3000/oauth/authorize?client_id=testclient&response_type=code&scope=openid&redirect_uri=https://httpbin.org/get&state=abc123&prompt=consent. It should skip the login page entirely and just ask you for an expiration date on an approval request. Hit approvehttp://localhost:3000/oauth/authorize?client_id=testclient&response_type=code&scope=openid&redirect_uri=https://httpbin.org/get&state=abc123&prompt=select_accountAnd select the cat account you have been using
http://localhost:3000/oauth/authorize?client_id=testclient&response_type=code&scope=openid&redirect_uri=https://httpbin.org/get&state=abc123&prompt=select_account