fix(ci): eliminate git tag race condition with dedicated set-git-tag job#71
Merged
Conversation
Multiple publishing workflows (docker, npm, python, release) were setting the same git tag in parallel, causing TOCTOU failures when two jobs passed the ls-remote check simultaneously but only one could push. Extracts tag creation into a single reusable set-git-tag.yml workflow called as a dedicated job before all publishing jobs, making every publisher depend on it via `needs`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publish-docker-image,publish-npm-libraries,publish-python-libraries,release-github) were all setting the same git tag in parallel, causing TOCTOU failures when two jobs passed thels-remotecheck simultaneously but only one could pushset-git-tag.yml, called as a dedicatedset_git_tagjob inbuild-test-publish.ymlaftersecurity_scan_artifactsand before all publishing jobsset_git_tagin theirneeds, so the tag is guaranteed to exist (or already existed) by the time any publisher runsTest plan
set_git_tagjob appears in the workflow run graph betweensecurity_scan_artifactsand the publishing jobs