Include Spans on internal parser AST objects#100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an enormously invasive change to make what seems like a minor improvement, but it is common that parsers produce abstract syntax trees that include information about the range of the the source that they came from.
While the parser itself is stateful and has the source location to hand when it encounters a problem, subsequent phases in the compiler do not have that information and if they want to refer back to the input that caused the problem they need that range information. This is now included in a Span struct on every parser internal AST type.
Also fixes a bug in the ranges being passed to lesser used code paths, so a net improvement in correctness.