fix: rebase fork deltas onto upstream v4.26.8 - #1
Closed
bowling233 with Copilot wants to merge 1 commit into
Closed
Conversation
Copilot
AI
changed the title
[WIP] Rebase fork's master branch onto upstream tag v4.26.8
fix: rebase fork deltas onto upstream v4.26.8
Jul 29, 2026
bowling233
pushed a commit
that referenced
this pull request
Jul 29, 2026
…eopened) (AstrBotDevs#8323) * fix: Faiss read/write on Windows with non-ASCII paths Bridge Faiss C++ fopen() ANSI codepage limitation through pure ASCII temp files using Python shutil. Also fix dtype=np.int64 for IDs, vector.reshape for search, and remove incorrect normalize_L2 on IndexFlatL2. * fix: narrow RuntimeError catch, add search validation, bridge only when needed Addresses bot review feedback on PR AstrBotDevs#8323: - Add _needs_bridge() helper to activate temp file bridge only on Windows + non-ASCII paths (Sourcery AstrBotDevs#5) - _read_index: re-raise RuntimeError when bridging not needed, preventing silent swallowing of genuine Faiss errors (Sourcery #1) - _write_index: skip temp file for ASCII/non-Windows paths (Sourcery AstrBotDevs#5) - search(): validate ndim==1 and dimension before reshape, preventing silent semantic corruption on 2D input (Sourcery AstrBotDevs#3, AstrBotDevs#4) - _safe_temp_dir & _make_temp_file: simplify (Sourcery AstrBotDevs#6, AstrBotDevs#7) - Remove redundant CWD fallback (never reached on non-ASCII paths) - Remove redundant UUID prefix (mkstemp O_EXCL guarantees uniqueness) All changes tested: 119/119 pass covering bridge logic, ASCII/non-ASCII paths, concurrent temp file uniqueness, search validation, and exception propagation. * style: ruff format * chore: ruff check fix * fix: make search() accept both 1D and 2D vectors, fix caller shape --------- Co-authored-by: Soulter <905617992@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased the fork-specific
masterdeltas onto upstreamAstrBotDevs/AstrBottagv4.26.8, while intentionally excluding the DingTalk patch already merged upstream (AstrBotDevs#9389). This keeps only the fork-maintained CI/docs additions and the MCP proxy behavior fix.Fork-only CI and maintenance docs
.github/workflows/docker-build.ymlAGENTS.mdMCP proxy behavior preserved after rebase
_quick_test_mcp_connectionin:astrbot/core/agent/mcp_client.pyastrbot/core/provider/func_tool_manager.pytrust_env=True.v4.26.8is intentionally limited to.github/workflows/docker-build.ymlAGENTS.mdastrbot/core/agent/mcp_client.pyastrbot/core/provider/func_tool_manager.pyOriginal prompt