Skip to content

fix(wizard): only persist cast members from fully-streamed lines #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Viscerous wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(wizard): only persist cast members from fully-streamed lines #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/components/wizard/StoryWizard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -582,7 +582,13 @@ function CharactersStep({
// As the cast streams in, progressively append parsed rows.
useEffect(() => {
if (!castGen.text) return
const parsed = parseCastList(castGen.text)
// The last line is usually still streaming, so parse only up to the last newline
// (fully-terminated rows); once the stream ends, parse everything.
const source = castGen.isStreaming
? castGen.text.slice(0, castGen.text.lastIndexOf('\n') + 1)
: castGen.text
if (!source) return
const parsed = parseCastList(source)
if (parsed.length === 0) return

const seen = seenStreamedNamesRef.current
Expand Down Expand Up @@ -616,7 +622,7 @@ function CharactersStep({
queryClient.invalidateQueries({ queryKey: ['fragments', storyId] })
}).catch(() => { /* best effort */ })
}
}, [castGen.text]) // eslint-disable-line react-hooks/exhaustive-deps
}, [castGen.text, castGen.isStreaming]) // eslint-disable-line react-hooks/exhaustive-deps

const handleSummon = () => {
seenStreamedNamesRef.current = new Set(characters.map(c => c.name.toLowerCase()))
Expand Down