fix(tools): editProse merge-patches content instead of overwriting the whole fragment#43
Open
Viscerous wants to merge 1 commit into
Open
fix(tools): editProse merge-patches content instead of overwriting the whole fragment#43Viscerous wants to merge 1 commit into
Viscerous wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
editProse was the only write path that overwrote the entire fragment from an up-front bulk read, so it (a) skipped versioning that every other edit records, and (b) could clobber metadata written concurrently by the librarian (e.g. inline character-mention annotations, running summary).
Switches editProse to updateFragmentVersioned with a content-only patch, which re-reads on write and preserves fields outside the patch, fixing the clobber, adding version history (bulk AI edits are now revertable), and skipping fragments that vanished between read and write rather than resurrecting them.
Test: tests/llm/tools.test.ts (editProse block; the version assertion fails on the old full-object path).
Note: touches the editProse loop, so it conflicts with #42, whichever lands second needs a trivial rebase.