fix(librarian): let the analyze pass read fragments before editing to prevent blind overwrites#41
Open
Viscerous wants to merge 1 commit into
Open
Conversation
… prevent blind overwrites
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The librarian analyze pass could rewrite fragment content without first reading the current state, and since it only has the shortlist + description could rewrite a fragment using only that knowledge, possibly deleting most of the fragment.
This gives the analyze pass read + targeted edit tools (analysis-tools.ts), wires them into the analyze block context (blocks.ts), and adjusts the agent (agent.ts) so it inspects a fragment before editing rather than overwriting blindly.