Skip to content

docs: add custom domain and sitemap for GitHub Pages#16

Merged
OriNachum merged 1 commit into
mainfrom
docs/custom-domain-and-sitemap
Apr 8, 2026
Merged

docs: add custom domain and sitemap for GitHub Pages#16
OriNachum merged 1 commit into
mainfrom
docs/custom-domain-and-sitemap

Conversation

@OriNachum

Copy link
Copy Markdown
Contributor

Summary

  • Configure open-bedrock-server.teabranch.dev as custom domain (CNAME)
  • Add jekyll-sitemap plugin for automatic sitemap.xml generation
  • Add footer_content to _config.yml to align with open-responses-server docs site
  • Update url and baseurl for custom domain routing

Manual steps after merge

  • Configure DNS: CNAME record open-bedrock-server.teabranch.devteabranch.github.io
  • Enable custom domain in GitHub repo Settings → Pages

Test plan

  • bundle install resolves jekyll-sitemap
  • bundle exec jekyll build succeeds
  • _site/sitemap.xml generated with correct domain URLs
  • _site/CNAME present in build output

🤖 Generated with Claude Code

  • Claude

Configure open-bedrock-server.teabranch.dev as custom domain, add
jekyll-sitemap plugin for sitemap.xml generation, and add footer_content
to align with open-responses-server docs site.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings April 8, 2026 22:10
@qodo-code-review

Copy link
Copy Markdown

Review Summary by Qodo

Configure custom domain and sitemap for GitHub Pages

📝 Documentation

Grey Divider

Walkthroughs

Description
• Configure custom domain open-bedrock-server.teabranch.dev via CNAME file
• Add jekyll-sitemap plugin for automatic sitemap generation
• Update site URL and baseurl for custom domain routing
• Add footer content to align with documentation standards
Diagram
flowchart LR
  A["docs/_config.yml"] -->|update URL config| B["Custom domain setup"]
  C["docs/CNAME"] -->|define domain| B
  D["docs/Gemfile"] -->|add jekyll-sitemap| E["Sitemap generation"]
  B -->|enable| F["open-bedrock-server.teabranch.dev"]
  E -->|generate| G["sitemap.xml"]
Loading

Grey Divider

File Changes

1. docs/CNAME ⚙️ Configuration changes +1/-0

Add custom domain CNAME file

• Create new CNAME file with custom domain open-bedrock-server.teabranch.dev
• Enables GitHub Pages custom domain routing

docs/CNAME


2. docs/Gemfile Dependencies +1/-0

Add jekyll-sitemap gem dependency

• Add jekyll-sitemap gem dependency for automatic sitemap generation

docs/Gemfile


3. docs/_config.yml ⚙️ Configuration changes +7/-2

Update Jekyll config for custom domain and sitemap

• Update baseurl from /open-bedrock-server to empty string for custom domain
• Update url from teabranch.github.io to open-bedrock-server.teabranch.dev
• Add jekyll-sitemap plugin to plugins list
• Add footer_content with MIT license attribution

docs/_config.yml


Grey Divider

Qodo Logo

@qodo-code-review

qodo-code-review Bot commented Apr 8, 2026

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (2)   📘 Rule violations (0)   📎 Requirement gaps (0)   🎨 UX Issues (0)
🐞\ ≡ Correctness (1) ⚙ Maintainability (1)

Grey Divider


Remediation recommended

1. README URLs outdated 🐞
Description
Changing docs/_config.yml to baseurl: "" and the new custom url makes the local-dev and
live-site URLs documented in docs/README.md incorrect. Contributors following the README will be
sent to /open-bedrock-server/ paths and the old GitHub Pages domain, which no longer match the
site configuration.
Code

docs/_config.yml[R4-5]

+baseurl: ""
+url: "https://open-bedrock-server.teabranch.dev"
Evidence
docs/_config.yml now configures an empty baseurl and a new custom-domain url, while
docs/README.md still instructs users to browse the site under /open-bedrock-server/ and
references the old teabranch.github.io/open-bedrock-server URL.

docs/_config.yml[1-6]
docs/README.md[24-30]
docs/README.md[122-125]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
`docs/README.md` still documents the old GitHub Pages URL and a `/open-bedrock-server/` base path, but `_config.yml` now uses a root baseurl and a custom domain. This makes the documented local and live URLs incorrect.

### Issue Context
With `baseurl: ""`, local serve URLs will be rooted at `http://localhost:4000/` (unless overridden via CLI). The `url` is now `https://open-bedrock-server.teabranch.dev`.

### Fix Focus Areas
- docs/README.md[24-30]
- docs/README.md[122-125]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


2. Ambiguous footer source 🐞
Description
The PR adds footer_content in docs/_config.yml while the site already defines footer text in
docs/_includes/footer_custom.html, creating two sources of truth for footer content. This
ambiguity can lead to inconsistent footer output (or duplicated license text) depending on theme
precedence and future upgrades.
Code

docs/_config.yml[R22-25]

+footer_content: >-
+  Open Bedrock Server — Licensed under
+  <a href="https://github.com/teabranch/open-bedrock-server/blob/main/LICENSE">MIT</a>.
+
Evidence
footer_content is newly configured with MIT license text, and there is already a custom footer
include that renders MIT license text (plus disclaimer). Keeping both makes the intended footer
implementation unclear and increases the risk of divergence.

docs/_config.yml[22-30]
docs/_includes/footer_custom.html[1-5]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
Footer content is now defined in both `_config.yml` (`footer_content`) and `_includes/footer_custom.html`, which creates an unclear precedence and a maintainability hazard.

### Issue Context
The site already has a custom footer include with license/disclaimer text; the new `footer_content` adds overlapping license text.

### Fix Focus Areas
- docs/_config.yml[22-30]
- docs/_includes/footer_custom.html[1-5]

### Suggested direction
Pick one mechanism:
- Either remove `footer_content` and keep `footer_custom.html`, or
- Remove/empty `footer_custom.html` and move the full desired footer (including the disclaimer) into `footer_content`.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@OriNachum OriNachum merged commit 5ac7ef3 into main Apr 8, 2026
6 checks passed
@OriNachum OriNachum deleted the docs/custom-domain-and-sitemap branch April 8, 2026 22:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Jekyll docs site configuration to support serving the documentation from a custom domain and to automatically generate a sitemap.xml for search engines.

Changes:

  • Add jekyll-sitemap (Gem + _config.yml plugin) to generate sitemap.xml.
  • Configure GitHub Pages custom domain via docs/CNAME and update Jekyll url/baseurl.
  • Add footer_content in _config.yml for consistent site footer branding.

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.

File Description
docs/Gemfile Adds jekyll-sitemap dependency
docs/Gemfile.lock Locks jekyll-sitemap and its resolved dependency set
docs/CNAME Declares the GitHub Pages custom domain
docs/_config.yml Sets url/baseurl, adds footer_content, enables jekyll-sitemap plugin
Comments suppressed due to low confidence (1)

docs/CNAME:2

  • The CNAME file currently has an extra blank line after the domain. GitHub Pages expects the file to contain just the custom domain value; please remove the trailing empty line/whitespace to avoid any parsing issues.
open-bedrock-server.teabranch.dev


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/_config.yml
baseurl: "/open-bedrock-server"
url: "https://teabranch.github.io"
baseurl: ""
url: "https://open-bedrock-server.teabranch.dev"

Copilot AI Apr 8, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

site.url is now hardcoded to the custom domain. Until the GitHub Pages custom domain is actually enabled (and actions/configure-pages updates its outputs), the deployed site URL may still be the teabranch.github.io/open-bedrock-server project page, but SEO tags and jekyll-sitemap will emit canonical/sitemap URLs for open-bedrock-server.teabranch.dev. Consider setting url at build time from actions/configure-pages outputs (or delaying this change until the domain is enabled) to avoid publishing incorrect canonical URLs during the transition. Also update docs/README.md’s “Live Site” link so it matches the new domain.

Suggested change
url: "https://open-bedrock-server.teabranch.dev"
url: ""

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants