Skip to content

Ratified changes from DwC-DP public review - #887

Merged
MattBlissett merged 41 commits into
masterfrom
dwc-changes-2026-05-26
Jun 9, 2026
Merged

Ratified changes from DwC-DP public review#887
MattBlissett merged 41 commits into
masterfrom
dwc-changes-2026-05-26

Conversation

@tucotuco

@tucotuco tucotuco commented Jun 5, 2026

Copy link
Copy Markdown
Member

Changes based on 2026-05-26 ratification of solutions from https://github.com/tdwg/dwc/milestone/20. The easiest way to review more thoroughly is by merging this pull request, but a sanity check before doing so is worthwhile.

tucotuco added 26 commits May 5, 2026 12:35
…h-cm-dp

Old branch dwc-changes-2026-04-07 has changes to three files not in new branch dwc-changes-2026-04-07-with-cm-dp.
@tucotuco
tucotuco requested a review from baskaufs June 5, 2026 08:15

@MattBlissett MattBlissett left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it would be useful for this large change, I could easily set up a temporary build of this branch to dwc-dev.tdwg.org or similar.

  • docs/em/2025-06-12.md is missing
  • datable and S*urveys* in dwc_doc_cm/index_template.md
  • new pages need to be added to the website menu in docs/_data/navigation.json

@tucotuco

tucotuco commented Jun 5, 2026

Copy link
Copy Markdown
Member Author

That would be awesome! Yes, please.

MattBlissett added a commit to tdwg/infrastructure that referenced this pull request Jun 5, 2026
@MattBlissett

Copy link
Copy Markdown
Member

See https://dwc-dev-preview.tdwg.org/, built using https://github.com/tdwg/dwc/blob/dwc-changes-2026-05-26/.github/workflows/dev-preview.yml#L35-L37

NB docs/list/2025-07-10.md also has unwanted changes.

@MattBlissett

Copy link
Copy Markdown
Member

After you push changes to this branch, you can check https://github.com/tdwg/dwc/actions to see that the build succeeds.

@baskaufs baskaufs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 3726e53 I'm seeing all of the double Executive Decisions (58 and 60) caused by running the rs.tdwg.org update script a second time. If the source decision-links.csv duplicate rows are removed and the list of terms build script is run again, they should go away. (This is related to my comments on the rs.tdwg.org pull request review.)

@tucotuco
tucotuco requested review from MattBlissett and baskaufs June 8, 2026 20:39

@baskaufs baskaufs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, John

@tucotuco

tucotuco commented Jun 9, 2026

Copy link
Copy Markdown
Member Author

If it would be useful for this large change, I could easily set up a temporary build of this branch to dwc-dev.tdwg.org or similar.

  • docs/em/2025-06-12.md is missing
  • datable and S*urveys* in dwc_doc_cm/index_template.md
  • new pages need to be added to the website menu in docs/_data/navigation.json

I believe I have addressed everything here except datable, which I believe to be correct.

@MattBlissett
MattBlissett merged commit f57db21 into master Jun 9, 2026
1 check passed
@MattBlissett
MattBlissett deleted the dwc-changes-2026-05-26 branch June 9, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants