fix(activity): use s_insert_or_update for lap persistence#321
Open
Carlixgonzam wants to merge 1 commit into
Open
fix(activity): use s_insert_or_update for lap persistence#321Carlixgonzam wants to merge 1 commit into
Carlixgonzam wants to merge 1 commit into
Conversation
replaced the s_exists + add pattern in _write_lap_entry with s_insert_or_update(ignore_none=True) so that existing lap rows are updated on re-import rather than silently skipped. This preserves legitimate zero-valued fields such as distance=0.0 for rest laps, and adds the missing min_temperature mapping to both _write_lap_entry and _write_session_entry
Owner
|
Looks good. Please retarget the PR against the develop branch. |
Author
|
perfect! I´ll do right know, if you need more documentation about this, I'll do it right now. Also I have to verify first if the integration with develop branch works well :) |
Owner
|
Any update? |
Author
hi! I left all my changes in develop branch, but I'm still working on other fixes that I found in the repo. I'm also making some test in my Garmin watch so if there's any other update I'll tell you. I could be interesting if we add some agents for improving the dashboards ;) 🫶🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replaced the s_exists + add pattern in _write_lap_entry with s_insert_or_update(ignore_none=True) so that existing lap rows are updated on re-import rather than silently skipped.
This preserves legitimate zero-valued fields such as distance=0.0 for rest laps, and adds the missing min_temperature mapping to both _write_lap_entry and _write_session_entry