Retry much more persistently#306
Open
pdavies wants to merge 1 commit into
Open
Conversation
Owner
|
Since we are no longer using garth, this change no longer applies. Can you look into whether there are comparable changes for GarminConnect? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there, thanks for creating this package, it's great! I can create an issue if needed but this seemed quicker.
I recently tried to onboard to GarminDB. My data stretches back to 2019, and even though garth has some retry behaviour, it wasn't enough. I found that the download of monitoring data would crash out somewhere during a series of ~7k queries with one error or another, at which point all that downloaded data would be lost and I'd need to start again. Eventually it became clear that although the error rate was low - maybe one every few thousand downloads - it was high enough to have a very small chance of actually completing the process.
One attractive way to deal with this would be to retain a partially downloaded state and resume it on the next attempt. But that sounds like effort! Instead this PR just expands greatly upon the default retries. The choice of parameters is fairly arbitrary. You may want to tweak it. But it successfully unblocked me, and I see little downside to a change such as this. It seems worthwhile to retry many times before throwing away thousands of downloads that have taken hours to retrieve!