fix(activity): remove gap above selected-file detail#34
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the Activity detail-layout correction for the v0.1.1 release.
Adds:
Scope
Included
VSplitViewwith a content-aware vertical layoutExcluded
Product / Architecture Decisions
Tableas the native data surface rather than replacing it with custom rows.User-Facing Contract
Human Output
The selected Activity detail now appears immediately after the final visible table row. The former black band between the table and detail is removed.
Verification
Ran
./script/build_and_run.sh --verifyswift testCovered
Review Path
DashboardView.activityContentActivityPaneMetricsNotes For Reviewer
The layout remains entirely SwiftUI and keeps the native
Table; the change only revises the vertical relationship between the table, selected detail, and spare canvas.