docs: added rule building flow document - #290
Conversation
Signed-off-by: Ahmad Khalid <ahmad.khalid@paysyslabs.com>
📝 WalkthroughWalkthroughAdds a 731-line deployment guide covering Rule Studio architecture, prerequisites, DevTestOps configuration, per-rule deployment, local simulation, publishing options, environment variables, known issues, smoke tests, and troubleshooting. ChangesRule Building Flow Documentation
Estimated code review effort: 3 (Moderate) | ~20 minutes Suggested labels: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 5
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Technical/Deployment-Guides/Rule` Building Flow.md:
- Around line 323-325: Update the npm authentication steps around the npm
registry login to avoid writing TAZAMA_TOKEN to the persistent ~/.npmrc; use a
temporary npm configuration or NODE_AUTH_TOKEN instead, and guarantee removal of
any temporary credentials with a cleanup trap after npm whoami completes.
- Around line 607-615: Update the “9.1 GitHub org secrets” table so
DOCKERHUB_NAMESPACE is classified consistently with section 8.2 as an
organization variable; remove it from the secrets table and ensure the variables
table documents its workflow consumption.
- Around line 339-351: The deployment guide must not present hardcoded database
or Redis credentials as production values. Update the environment-variable table
and related docker run instructions around RAW_HISTORY_DATABASE_PASSWORD,
POSTGRES_PASSWORD, and REDIS_PASSWORD so environment-specific secrets are
explicitly read and passed through, or clearly label these entries as
non-production placeholders and document the required Redis secret override.
- Around line 187-188: Update the health check and bootstrap examples in the
deployment guide to use the configured PORT value or a clearly documented port
placeholder instead of hardcoding 3050. Apply this consistently to the examples
near the PORT configuration table and the referenced sections, while preserving
the existing command behavior.
- Around line 145-168: Update the AES example’s key and IV handling to match the
documented openssl hex output: decode ENCRYPTION_KEY and ENCRYPTION_IV as hex
instead of UTF-8, and revise the surrounding comments and byte-length
verification note to describe the decoded 32-byte key and 16-byte IV.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 17be0fb5-96cb-47ab-b4af-a12dfc805a8d
📒 Files selected for processing (1)
Technical/Deployment-Guides/Rule Building Flow.md
SPDX-License-Identifier: Apache-2.0
What did we change?
Added a new documentation file
Technical/Deployment-Guides/Rule Building Flow.mddescribing the rule building flow.Why are we doing this?
To provide clear, centralized documentation on the rule building process for contributors and operators referencing the deployment guides.
How was it tested?
Summary by CodeRabbit