fix: pass scope argument to createBackup in permissions test#38
Open
tikibozo wants to merge 1 commit into
Open
fix: pass scope argument to createBackup in permissions test#38tikibozo wants to merge 1 commit into
tikibozo wants to merge 1 commit into
Conversation
createBackup gained a scope parameter in tawanorg#33, but the permissions test from tawanorg#24 still calls it with no arguments, breaking the build of the test binary (go test ./cmd/claude-sync fails to compile on main). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go test ./cmd/claude-syncfails to compile on currentmain:createBackupgained ascopeparameter in #33, but the permissions test added in #24 still calls it with no arguments — the two landed independently so neither PR could see the conflict. This passes"full"(the default scope), matching the test's setup which creates files across all sync paths.Testing
go test ./...passes.🤖 Generated with Claude Code