Feat/#248 리팩토링#252
Closed
hwanghyojin wants to merge 47 commits into
Closed
Conversation
🎨 UI Review (Chromatic)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
📝 작업 내용
💬 리뷰 요구사항(선택)
entities로 넣어야 할지 애매했던 영역에 대해,
FSD 공식 문서와 현재 프로젝트 컨벤션을 기준을 고려해서
dashboard와 notification을 entities 폴더에 위치하는걸로 정리했습니다.
이후에 각자의 기준으로 폴더를 수정하거나 하셔도 좋을 것 같습니다.
최대한 다른 영역의 파일은 건드리지 않는 방향으로 작업하여
management의 경우 team의 API 정의 등 중복되는 부분들이 존재합니다.
이 점 참고하여 추후에는 각자의 기준으로 정리해 나가면 좋을 것 같습니다.