fix(doctor): report effective per-directory identity, not just global#34
Merged
Conversation
doctor read the git identity via git.GlobalIdentity() (git config --global), so it always printed the global user.name/email and ignored the includeIf blocks gitswitch itself writes to bind a directory to an identity. In a bound directory it reported the wrong identity even though commits went out correctly — a display bug, not a behavior bug. Switch the git row to git.EffectiveIdentity() (git config without --global, which respects local repo config and includeIf chains), and additionally show the global identity when it differs so the switch is visible. Add EffectiveIdentity() mirroring GlobalIdentity, plus a regression test that a local override wins over global.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
doctor read the git identity via git.GlobalIdentity() (git config --global), so it always printed the global user.name/email and ignored the includeIf blocks gitswitch itself writes to bind a directory to an identity. In a bound directory it reported the wrong identity even though commits went out correctly — a display bug, not a behavior bug.
Switch the git row to git.EffectiveIdentity() (git config without --global, which respects local repo config and includeIf chains), and additionally show the global identity when it differs so the switch is visible. Add EffectiveIdentity() mirroring GlobalIdentity, plus a regression test that a local override wins over global.