Drain pending writes before handling rename or delete - #2
Merged
Conversation
sssciel
approved these changes
Jul 31, 2026
bigbes
force-pushed
the
bigbes/tntp-3131-drain-before-rename
branch
from
July 31, 2026 14:41
0e16f7e to
e261567
Compare
Mockird31
approved these changes
Aug 4, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A write and rename can make both Modified and Deleted ready at the same time. Even with the existing Modified pre-check, Go can select Deleted and close or reopen the file before unread bytes from the old descriptor are consumed.
Related: nxadm#72