ts_tunnel: use carrier structs to pass global and peer state to handshakes - #376
Merged
Conversation
nrc
approved these changes
Aug 19, 2026
nrc
left a comment
nrc
left a comment
Contributor
There was a problem hiding this comment.
Just two nits. This is a nice refactoring!
…hakes Updates #339 Signed-off-by: David Anderson <danderson@tailscale.com> Change-Id: I3723948a6807c0c92946ca1c423c21be6a6a6964
danderson
force-pushed
the
push-wsxwqvrptrzs
branch
from
August 19, 2026 16:54
758a36f to
a151aa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates #339
Change-Id: I3723948a6807c0c92946ca1c423c21be6a6a6964
Followup to #368, which greatly shrinks function signatures by formalizing that there is a carrier for endpoint-global state and one for peer configuration, and passing those to the handshake logic instead of handing out bits and pieces of each. These two carrier structs are the existing EndpointState and PeerConfig, with the latter having the peer ID folded into it.