feat: add tests, fix typo, extract constant, bump deps - #2
Merged
Conversation
- Add 6 tests covering nil receiver, invalid fd, invalid path, regular file, device enumeration, and capability constant - Fix typo: fileDesciptor -> fileDescriptor - Extract magic number 69206017 into V4L2CapVideoCapture constant - Bump golang.org/x/sys v0.41.0 -> v0.42.0 - Bump Go 1.26.0 -> 1.26.1 - Add staticcheck to CI workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
cap.QueryFdnil receiver, invalid fd,IsVideoCapturewith invalid path and regular file,EnumeratedVideoDevicessmoke test, andV4L2CapVideoCaptureconstant verificationfileDesciptor→fileDescriptorinQueryFdparameter name69206017→ namedV4L2CapVideoCaptureconstant with documentationgolang.org/x/sysv0.41.0 → v0.42.0