fix: 'ignore' policy now bypasses max_failed_ratio check - #43
Conversation
The `ignore` policy should return all tiles (filling failures with NoData) regardless of the failure ratio. Previously, the `max_failed_ratio` check was applied to all policies, causing the download to abort incorrectly under the `ignore` policy if too many tiles failed. This change gates the `max_failed_ratio` check to only apply when the policy is set to `lenient`. Closes #41 Co-authored-by: tahamukhtar20 <91777330+tahamukhtar20@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
tahamukhtar20
changed the title
1 participant
This PR addresses issue #41 where the
ignorefailure policy was incorrectly enforcing themax_failed_ratiothreshold.Changes:
src/lib.rsto only apply themax_failed_ratiocheck infetch_tileswhen the policy is"lenient".tests/test_fetcher.pyto verify that theignorepolicy correctly bypasses the ratio check even if all tiles fail.Verified by running all tests with
uv run pytest. All 215 tests passed.PR created automatically by Jules for task 15944298117911183194 started by @tahamukhtar20