Address post-merge review feedback from PR #74

[Freddyminu]

Summary

• Fix TypeScript error: `React.SyntheticEvent` had no `React` namespace in scope; replaced with `SyntheticEvent` from named import
• Delete ~74 lines of dead DocSearch CSS accidentally introduced by PR Doc gap feedback form in every page footer #74 (Algolia is being replaced on a parallel branch)
• Remove early return guard so the feedback FAB renders on every doc page, not only pages with tags or edit metadata
• Replace manual `EditMetaRow` markup with `@theme/EditMetaRow`, eliminating duplicated layout and the leftover inline `style={{ textAlign: "right" }}`
• Fix FAB/drawer accessibility: add `aria-expanded`, `aria-controls`, `tabIndex`, `aria-hidden` to the FAB; remove the unsupported `aria-modal` from the non-modal drawer; return focus to the FAB on close and Escape
• Convert both `DocItemFooter` and `FeedbackForm` to arrow functions per AGENTS.md convention
• Add `console.error` in the fetch catch block so HubSpot submission failures are visible in production logs
• Reset form state (`feedback`, `email`, `status`) via `useEffect` keyed on the `open` prop instead of relying on a remount key
• Add `AbortSignal.timeout(10000)` to the HubSpot fetch so the form cannot get stuck in "Sending..." indefinitely
• Replace `--ifm-color-danger` and `--ifm-color-white` for the required marker and submit button (previously hardcoded `#e53e3e` / `#fff`)
• Move HubSpot IDs from `secrets` to `vars` in both deploy workflows — these are public client-side values, not credentials
• Separate the IntersectionObserver sentinel (`
  `) from the `` element so the footer only renders when it has content (tags or edit metadata)

Feedback FAB placement

The feedback UI is a fixed-position FAB in the bottom-right corner, not a button inline with "Edit this page". The FAB appears the first time the bottom of the doc page scrolls into the viewport and remains visible for the rest of the session — it does not re-trigger the entrance animation on every page navigation.

Closes #74

[Freddyminu]

This PR responds to the comments from @felipefdl in this PR: #74

Working on the last comment from that page.

[Freddyminu]

Github Vars added, need to remove unused secrets once deployed.

[felipefdl]

Thanks for the follow-up. PR 77 closes the worst landmine (DocSearch CSS conflict with #218) plus a TS error and accessibility gaps, but most of the post-merge review on #74 is still open. Requesting changes so the rest gets addressed before merge.

Fixed in this PR

• #1 DocSearch CSS scope creep (Critical). 74 lines deleted.
• #10 Feature gated on hasTags || hasEditMeta (Suggestion). Early return removed, FAB now renders on every doc page.
• #8 (partial) Hardcoded DocSearch hex colors. Gone with the DocSearch block.

Improvements added beyond my review (nice)

• TypeScript fix: React.SyntheticEvent to named SyntheticEvent import.
• Replaced manual edit-meta markup with @theme/EditMetaRow. Kills the inline style={{ textAlign: "right" }}.
• Arrow-function conversion per AGENTS.md.
• Real a11y upgrades: aria-expanded, aria-controls, tabIndex, aria-hidden on the FAB. Removed the bogus aria-modal from the non-modal drawer. Focus returned to FAB on close and Escape.

Still open (requesting changes)

Critical

• #2 Silent failure in catch block. Footer/index.tsx:188-190 still has catch { setStatus("error"); } with no logging. Add console.error(err) at minimum so production failures are debuggable.
• #3 FAB vs inline-button spec mismatch. PR #74 description said "next to Edit this page" but the implementation is a fixed-position FAB. Either update the spec or move the button inline.

Important

• #4 formKey remount trick still in place. Reset state explicitly in FeedbackForm via useEffect keyed on a prop, or lift state to the parent.
• #5 as string double casts. Type guard is not expressed in the type system. Narrow once with an early return.
• #6 No fetch timeout. If HubSpot hangs, the form stays in "Sending..." forever. Use AbortSignal.timeout(10000).
• #7 z-index magic numbers (199 / 200) collide with the Docusaurus navbar layer. Use a defined scale or document the reason.
• #8 (remaining) #e53e3e (required marker) and #fff still hardcoded. Replace with --ifm-color-danger and --ifm-color-white (or equivalent).
• #9 Public values treated as repo secrets. HUBSPOT_PORTAL_ID / HUBSPOT_DOC_GAP_FORM_ID get bundled in client JS and sent in the URL to a public HubSpot endpoint. Move to repo variables (vars.HUBSPOT_PORTAL_ID) instead of secrets in both workflows.

Suggestions

• #11 No tests for a 239-line interactive component (form, observer, escape handler, success timeout, HubSpot submission).
• #12 "Bounces once when the footer first scrolls into view" still resets visible on every permalink change, so it bounces on every navigation. Either match the description or update the description.

One new nit introduced by this PR

Footer/index.tsx:75-81 always renders the <footer> (needed for the IntersectionObserver ref) but conditionally applies its classes via clsx. When !hasTags && !hasEditMeta, the DOM ends up with an empty unstyled <footer> element. Functionally fine, semantically odd. Splitting the observer target from the footer element would be cleaner. Not a blocker.

Summary

The PR body says "Closes #74" but it closes roughly 3 of 12 issues from the post-merge review. Happy to approve once the Critical items (#2, #3) and the Important items above are addressed. Tests (#11) can land in a follow-up if scope is a concern.

[Freddyminu]

Yes, I'm currently working on the other commit.

[felipefdl]

Great turnaround on the fixes. 8 of 10 open items closed cleanly.

Now fixed

• Critical changing the documentation and fixing broken links #2 Silent catch. catch (err) { console.error(err); setStatus("error"); }. Done.
• Important Improve Youtube Videos Responsiveness LCD-148 #4 formKey remount removed. FeedbackForm now resets its own state via useEffect keyed on open.
• Important feat: adds community to the navbar #5 as string casts replaced with proper type narrowing through feedbackConfig. Clean.
• Important Fix Documentation Hyperlinks #6 Fetch timeout via signal: AbortSignal.timeout(10000).
• Important JUST A TEST #7 z-index magic numbers replaced with --z-doc-gap-fab: 199 and --z-doc-gap-drawer: 201, plus a comment explaining the scale relative to the Docusaurus navbar (200). The drawer at 201 is an actual fix, not just renaming (200 would have collided).
• Important Fixed the network integration hiperlink #8 Hardcoded #e53e3e and #fff replaced with var(--ifm-color-danger) and var(--ifm-color-white).
• Important Improve TagoCore Documentation for Beginners #9 Both workflows now use vars.HUBSPOT_PORTAL_ID / vars.HUBSPOT_DOC_GAP_FORM_ID.
• Suggestion Add files via upload #12 Bounce-once. setVisible(false) removed from the permalink effect, so visible stays true once set. Matches the original description.
• Previous nit (empty <footer>) Split cleanly: sentinel <div ref={sentinelRef} /> for the observer, <footer> only rendered when hasTags || hasEditMeta.

Still open before approval

• Critical TCORE-296 Documentation Work #3 FAB vs inline-button spec mismatch. The implementation is still a fixed-position floating action button at bottom-right. PR Doc gap feedback form in every page footer #74 description and issue Add "Report a doc gap" button to documentation pages #64 say "next to Edit this page." This is a design decision, not a code bug, so I am not asking you to refactor without confirmation. Pick one:

  1. FAB is the intended design. Update issue Add "Report a doc gap" button to documentation pages #64 and PR Doc gap feedback form in every page footer #74 history (a comment is enough) so the spec matches reality.
  2. Inline is the intended design. Refactor to render the button inside the edit-meta row.

  Once that call is made and reflected somewhere durable, I will dismiss the change request.

• Suggestion add image #11 Tests. Still no tests for the 239-line component. Fine to defer to a follow-up issue if you open one.

Keeping the changes-requested status until #3 has a decision.