Conversation
Constant one-day trim (front tau + back 24-tau) keeps the same T_days in the training/testing set at every tau: identical day sample across sweeps, tau-independent tensor shapes, and exact 24-hour block pooling. Scoring all days would need one extra routed day of q' per window (~1% signal), deliberately deferred. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…irms All arms complete: aorc2f distributed 0.706, UH retro 0.707, daily LSTM 0.578, hourly LSTM 0.564 (legacy-eval path), aorc2f lumped 0.483. The lumped arm regressing at tau=9 is the pre-registered prediction (its optimum is ~-8 on the new scale) — the one arm the fix should hurt, hurt. Adds the Phase-2 resume gotcha to the skill reference. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #33, which merged while two retrain arms were still evaluating. This PR carries the completed five-arm results table into the findings doc and skill reference, plus the doc comment on
tau_trim_and_downsampleexplaining why the slice excludes one day (constant sample across tau values; details in the comment).Final tau=9 retrain results (all five arms)
Full test window 1995-10..2010-09, 1,841 gauges, 30 epochs each, CPU:
The timing correction is worth +0.086 median NSE on the flagship arm and the routing now beats the summed-q' baseline by +0.064. The negative control held: the lumped store's measured optimum is about −8 on the new scale, tau=9 was predicted to hurt it, and it did (0.510 → 0.483).
Why tau = 9: UTC vs local time and inverse routing, following Bindas et al. (2024)
Bindas et al. (2024, the dMC Juniata study) handled model/observation timing with two separate corrections, and the new
tau: 9default maps onto that treatment as follows.1. The UTC vs local-time term. In the 2024 study the forcing was UTC and the USGS hourly observations were UTC−5, corrected by a 5-hour shift of the runoff before anything else. In ddrs the same concern exists in principle (AORC/q' stores on UTC day boundaries, USGS daily values on local standard time), and the sweep campaign tested for it directly: a routing-free control (summing upstream q' with no Muskingum-Cunge and sweeping the same pooling windows) measures the net convention offset at 0 to 2 hours (
docs/2026-08-06-tau-sweep-pilot-findings.md§5g). At daily resolution the store and observation day conventions net out to near-UTC-day alignment, largely because the q' generator was itself trained day-aligned against these observations, so its unit hydrograph absorbed any label offset. The 2024 paper's 5-hour term therefore contributes nothing here and no separate timezone shift is applied.2. The inverse-routing term. The 2024 study then shifted the runoff back in time by tau = 9 hours because the LSTM, trained at basin outlets with catchment area as an input, already implicitly contained the time of concentration, and the explicit routing module simulates that concentration again.
tau: 9in ddrs is the same operation with the same sign and, empirically, the same magnitude: the q' stores were exported with each divide's runoff already routed through dHBV's learned gamma unit hydrograph (median kernel mean 1.5 days per divide, growing with upstream area), so the MC network routes water whose travel time is partly pre-applied. The measured over-delay is 6 to 9 hours at the median gauge (routed optimum at tau=20 on the legacy scale, i.e. +9 hours past day-aligned), and the signed-at-zero convention makes the correction literal: advance the routed output by 9 hours before daily scoring, exactly the paper's "shift the runoff back in time by tau hours" as a translation-only stand-in for full inverse routing (Pan & Wood, 2013).In short: of the two timing terms in Bindas et al. (2024), the timezone term measures out to ~zero for CONUS daily scoring, and tau = 9 carries the inverse-routing term, whose root cause here is the double-carried gamma-UH travel time in the q' export (findings §5g/§5h). tau remains a compensation; the store-side fix (sub-grid-only UH) is the documented follow-up.
🤖 Generated with Claude Code